On Thu, 25 Sep 2025 18:40:27 GMT, Sergey Bylokhov <[email protected]> wrote:
>> This PR fixes one more issue preventing
>> `test/jdk/java/awt/print/PrinterJob/PrintTextTest.java` from being removed
>> from the problem list on macOS. The issue is the placement of line 8
>> ("GlyphVector with position adjustments") during printing. There were two
>> issues: (a) the necessary transform was being applied to each glyph
>> position, but not to the initial start position, and (b) the y-advances were
>> being unnecessarily inverted. This last one is a head-scratcher, because it
>> seems very intentional, but seems to generate incorrect results (every
>> second character was drawing below the line instead of above it).
>
> It seems PrintTextTest catches too many issues, can we create a small test to
> cover just this patch?
>@mrserb I tried writing a smaller automated test for this change, using
>PostScript to make it possible to "print" without printing and then roughly
>extract the bounds of the text from the generated PostScript, but it doesn't
>exercise the code in CTextPipe.m. I think this requires the manual testing
>provided by PrintTextTest.
ok, sounds good
-------------
PR Comment: https://git.openjdk.org/jdk/pull/27486#issuecomment-3344814355
