On Fri, 22 Aug 2025 22:16:48 GMT, Phil Race <[email protected]> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   javadoc update
>
> I don't think you are capturing what is going on here.
> The cases here are that y=0 so you can't scroll up, because you are at the 
> top.
> You don't ordinarlly see this in the positive direction because the cell that 
> is returned is null for out of range, and otherwise it at least points to the 
> TOP of the last cell. 
> But I'm not sure how you can actually scroll, because the returned increment 
> would take you off the bottom of the list, 
> And if the rectangle you pass in has a y that is = the height of the list, 
> then scrolling in a positive direction also returns 0.
> If it is GREATER than the height, then I get back a negative increment !
> 
> So this needs quite a bit more than the suggested words, because they aren't 
> accurate or nearly sufficient.
> I think a code fix might be needed too.
> I can even get a negative scroll value from the upwards direction.
> All you have to do is pass a synthesized rect to the API. 
> The implementation doesn't seem to be expecting that and it should probably 
> do something in response, but it may be too late from a compatibility point 
> of view. 
> I need you to figure this all out.

Hi @prrace , this one also needs a recheck from your side as I have updated the 
code to handle negative scrollvalue so now in all cases, whatever I tested, its 
returning a positive value which is mentioned now in the spec..

-------------

PR Comment: https://git.openjdk.org/jdk/pull/26500#issuecomment-3478932107

Reply via email to