On Mon, 15 Sep 2025 17:52:16 GMT, Phil Race <[email protected]> wrote:
>> Srinivas Mandalika has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fixed whitepsace error. > > test/jdk/java/awt/Modal/PrintDialogsTest/PrintDialogsTest.java line 65: > >> 63: "Verification step:\n" + >> 64: "Button is presseed - only if Modality Selection was 'Non-modal' >> or 'Modeless'.\n" + >> 65: "In all other cases, Window (3) should block input to Windows >> (1) and (2).\n\n" + > > I'm not sure this is correct. Document modal is not discussed here and its > behavior will depend on the parent selection. If it is Dialog or Frame it > will block. If it hidden or NULL, it won't block. > I see that on Mac and it makes sense if we consider that only in the > Dialog/Frame cases are we making these the parent of the modal dialog. I've > not tried other platforms but you should check but this is core AWT behavior > so I hope it is the same. Fixed. Verified the behavior of all modes on Windows 11 x64, Ubuntu 25.10 x64 and Mac OSX 15 aarch64. Modified instructions to detail out scenarios for all modality types. Included behavior for document modal with parent as dialog/ frame and others as well. Fixed a missing break in switch case of Test.java causing a test bug. Instructions screen shot attached for reference. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/27139#discussion_r2487039940
