On Tue, 4 Nov 2025 03:13:01 GMT, Prasanta Sadhukhan <[email protected]>
wrote:
>> If we pass null as highlight and shadow color to
>> `BorderFactory.createBevelBorder` and `createSoftBevelBorder`
>> it throws NPE which is not mentioned in the spec as the expected outcome.
>> Fixed the NPE and the spec
>
> Prasanta Sadhukhan has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - javadoc update
> - javadoc update
src/java.desktop/share/classes/javax/swing/BorderFactory.java line 151:
> 149: * If shadow color is {@code null}, the shadow color
> 150: * is derived from the specified component's background color.
> 151: * If bevelType is not of known type that is neither
Suggestion:
* If bevel type is not of known type that is neither
src/java.desktop/share/classes/javax/swing/border/BevelBorder.java line 80:
> 78: * colors will be derived from the background color of the
> 79: * component passed into the paintBorder method.
> 80: * If bevelType is not of known type that is neither
Suggestion:
* If bevel type is not of known type that is neither
src/java.desktop/share/classes/javax/swing/border/BevelBorder.java line 101:
> 99: * If shadow color is {@code null}, the shadow color
> 100: * is derived from the specified component's background color.
> 101: * If bevelType is not of known type that is neither
Suggestion:
* If bevel type is not of known type that is neither
src/java.desktop/share/classes/javax/swing/border/BevelBorder.java line 121:
> 119: * If any of the shadow color is {@code null}, the shadow color
> 120: * is derived from the specified component's background color.
> 121: * If bevelType is not of known type that is neither
Suggestion:
* If bevel type is not of known type that is neither
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27949#discussion_r2488905474
PR Review Comment: https://git.openjdk.org/jdk/pull/27949#discussion_r2488903938
PR Review Comment: https://git.openjdk.org/jdk/pull/27949#discussion_r2488906543
PR Review Comment: https://git.openjdk.org/jdk/pull/27949#discussion_r2488907065
