On Fri, 7 Nov 2025 03:35:41 GMT, Prasanta Sadhukhan <[email protected]>
wrote:
>> Test is made headless
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Review fix
Marked as reviewed by aivanov (Reviewer).
test/jdk/javax/swing/text/GlyphView/TestGlyphBGHeight.java line 59:
> 57:
> 58: public static void main(String[] args) throws Exception {
> 59:
I would also remove the blank line at the start of the `main` method.
test/jdk/javax/swing/text/GlyphView/TestGlyphBGHeight.java line 85:
> 83: System.out.println(Integer.toHexString(col));
> 84: if (col == Color.YELLOW.getRGB()) {
> 85: throw new RuntimeException(" Background is painted taller
> than needed for styled text");
Suggestion:
throw new RuntimeException("Background is painted taller than
needed for styled text");
There should be no space at the start of the message.
-------------
PR Review: https://git.openjdk.org/jdk/pull/28173#pullrequestreview-3435685180
PR Review Comment: https://git.openjdk.org/jdk/pull/28173#discussion_r2504959362
PR Review Comment: https://git.openjdk.org/jdk/pull/28173#discussion_r2504955991
