On Mon, 22 Dec 2025 02:34:14 GMT, Alexander Zvegintsev <[email protected]> wrote:
>> test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/ButtonActionKeyTest/ButtonActionKeyTest.java >> line 92: >> >>> 90: frame.setVisible(true); >>> 91: Util.waitForIdle(robot); >>> 92: robot.delay(1000); >> >> Isn’t it suspicious that it is not possible to show the frame quickly? I >> mean, 1 second is quite a long time. Is there any possibility to improve >> this on the toolkit side? > >> Isn’t it suspicious that it is not possible to show the frame quickly? I >> mean, 1 second is quite a long time. Is there any possibility to improve >> this on the toolkit side? > > This is just a precaution, and bringing it to a standard format for our tests > `setVisible` / `waitForIdle` / `delay`. > Whether it's 1000 ms or 500 ms doesn't change anything for the test; it can > still fail intermittently. > >> test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/ButtonActionKeyTest/ButtonActionKeyTest.java > The test may still fail intermittently in the CI, but an additional delay > after setVisible won't cause any problems / > https://bugs.openjdk.org/browse/JDK-8257529 but it passed before on x11, correct? so it mighte be usefull to investigate why we need this delay now. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28939#discussion_r2641393074
