On Tue, 23 Dec 2025 20:02:11 GMT, Damon Nguyen <[email protected]> wrote:
>> This update is to fix the potential issue where tmpbuf can be read as a
>> format argument for `fprintf`. I have added a specifier here to avoid this
>> issue since the string from tmpbuf is not guaranteed to not cause issues.
>> This update should make this print more reliable and safe to use.
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fputs and copyright
Changes requested by aivanov (Reviewer).
src/jdk.accessibility/windows/native/toolscommon/AccessInfo.cpp line 100:
> 98: vsnprintf(tmpbuf, sizeof(tmpbuf), msg, argprt);
> 99:
> 100: fputs(tmpbuf, logfile);
Since `fputs` doesn't add a line break automatically, you have to add it
explicitly.
fputs(tmpbuf, logfile);
fputs("\n", logfile);
-------------
PR Review: https://git.openjdk.org/jdk/pull/28950#pullrequestreview-3609245483
PR Review Comment: https://git.openjdk.org/jdk/pull/28950#discussion_r2644193662
