On Wed, 21 Jan 2026 00:01:29 GMT, Sergey Bylokhov <[email protected]> wrote:

>> Phil Race has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   8375351
>
> src/java.desktop/share/classes/javax/print/StreamPrintServiceFactory.java 
> line 77:
> 
>> 75:      */
>> 76:     private static Services getServices() {
>> 77:         return SERVICES;
> 
> Can SERVICES be eliminated completely? Previously, services acted as a bridge 
> between the client and listOfFactories (via the per-app context). Now there 
> is a 1-to-1 mapping.

I had thought of that when doing the fix but I figured it was easier to review 
if I kept it and just got rid of the AppContext .. but since you are asking for 
it, I've done it. Please review :-)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29237#discussion_r2717954996

Reply via email to