> Some of the medialib native functions implementing Convolve read data from > arrays when it is not needed or used instead of reading just what is needed > and used. > This is detected as a read out of bounds. It is limited and hasn't been seen > to result in any crashes without ASAN, and the OOB values that are read are > never used so there's a very limited problem. > The changes here make the mlib_ImageConv_*nw.c files match what happens in > the mlib_ImageConv_*ext.c files which read just the data they need. > The changes are fairly mechanical but there could be copy/paste errors for a > reviewer to find. > > Not easy to provide a test case, building with --enable-asan is needed and > for me it works only on macOS. > I did that and ran all our existing automated tests on our CI systems.
Phil Race has updated the pull request incrementally with one additional commit since the last revision: 8373626 ------------- Changes: - all: https://git.openjdk.org/jdk/pull/29257/files - new: https://git.openjdk.org/jdk/pull/29257/files/d7c258f0..97dc5cba Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=29257&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=29257&range=01-02 Stats: 2 lines in 1 file changed: 0 ins; 2 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/29257.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/29257/head:pull/29257 PR: https://git.openjdk.org/jdk/pull/29257
