On Fri, 23 Jan 2026 05:11:37 GMT, Prasanta Sadhukhan <[email protected]> wrote:
> Arrow icon of JMenuItem in JMenu which is used to invoke the submenu overlaps > with the menutext if the text is long. > > Fix is made to add a gap for arrow icon rect too similar to menu text and > accelerator rects I'm not completely against this as an *interim* fix… Yet the submenu arrow now is nearly at the very edge of the menu — there has to be a margin. When the submenu opens, it now covers the arrow, but it shouldn't. At least this is how it looks in native Win32 applications. This fix is yet another patch to fit more information into the same amount of space. The underlying problem remains unaddressed. In the fix for [JDK-8348760](https://bugs.openjdk.org/browse/JDK-8348760) in #23324, you **added** *another column* into Windows L&F menu layout, but you didn't increase the width of the menu to accommodate for the new column. Instead, you're trying to tweak coordinates of each element in the menu layout to fit more information into the same space. I keep saying since that initial code review for #23324, for example [here](https://github.com/openjdk/jdk/pull/23324#issuecomment-3008665338), and I repeat it here: > *The popup menu has to become wider if both check marks / bullets and icons > are rendered at the same time.* Unless you make the menu wider to accommodate the newly added column, the menu looks crammed with inconsistent margins between elements. ------------- PR Review: https://git.openjdk.org/jdk/pull/29375#pullrequestreview-3713721845
