On Mon, 2 Mar 2026 03:06:09 GMT, Prasanta Sadhukhan <[email protected]> 
wrote:

>> After [JDK-8373239](https://bugs.openjdk.org/browse/JDK-8373239):, Printing 
>> ALL pages results in NPE for 1.1 PrintJob because of lack of set pageranges 
>> citing
>> 
>> Exception in thread "AWT-EventQueue-0" java.lang.NullPointerException: 
>> Cannot invoke "javax.print.attribute.standard.PageRanges.getMembers()" 
>> because "range" is null
>>         at 
>> java.desktop/sun.print.PrintJobDelegate.updateAttributes(PrintJobDelegate.java:529)
>>         at 
>> java.desktop/sun.print.PrintJobDelegate.printDialog(PrintJobDelegate.java:424)
>>         at java.desktop/sun.print.PrintJob2D.printDialog(PrintJob2D.java:65)
>>         at 
>> java.desktop/sun.awt.windows.WToolkit.getPrintJob(WToolkit.java:644)
>>         at 
>> java.desktop/sun.awt.windows.WToolkit.getPrintJob(WToolkit.java:629) 
>> 
>> A null check is now added as we are now removing PageRange attribute if not 
>> set..It works fine for PrinterJob but fails for 1.1 PrintJob as 
>> PrintJobDelegate.updateAttributes called in 1.1 PrintJob use pageRange 
>> variable without checking if it exists.
>
> Prasanta Sadhukhan has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   jcheck

test/jdk/java/awt/PrintJob/TestPrintNoException.java line 36:

> 34:  * @build PassFailJFrame
> 35:  * @summary Verifies No Exception is thrown when Printing "All" pages
> 36:  * @run main/manual TestPrintNoException

https://docs.oracle.com/en/java/javase/25/docs/api/java.desktop/java/awt/JobAttributes.DialogType.html
 can be NONE
And then the test can be automated.
Or does the exception only happen if there was a dialog displayed ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29874#discussion_r2886444114

Reply via email to