On Wed, 25 Feb 2026 11:08:49 GMT, Prasanta Sadhukhan <[email protected]> 
wrote:

>> `JProgressBar` is not printed if JDK 1.1 printing API is used.
>> JDK1.1 printing API `PrintJob ` doesn't support `Graphics2D`. 
>> JProgressBar seems to require Graphics2D as `BasicProgressBarUI` needs 
>> Graphics2D to do
>> `g2.setStroke(new BasicStroke(...))`
>> 
>> Fix is made to not rely on setStroke for non-Graphics2D printing case and 
>> also not to clip progress string
>> Also, a null pagerange check is added for PrintJobDelegate as we reset 
>> PageRanges if range is not set so to prevent NPE when "All" is used in print 
>> dialog instead of "Pages from"
>
> Prasanta Sadhukhan has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Remove PageRange regression, fix Synth

src/java.desktop/share/classes/javax/swing/plaf/basic/BasicProgressBarUI.java 
line 892:

> 890:         }
> 891: 
> 892:         Graphics g2d = null;

g2d does not seem to be used at all.
In which case you can eliminate all mention of it.
lines 887-895 can just be deleted, can't they ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29752#discussion_r2886620680

Reply via email to