On Mon, 23 Mar 2026 04:37:02 GMT, Renjith Kannath Pariyangad
<[email protected]> wrote:
>> Hi Reviewers,
>>
>> I have updated the method with `for loop` and `==` so the code will mach
>> with `addInvalidComponent`
>>
>> Please review and let me know your suggestions
>
> Renjith Kannath Pariyangad has updated the pull request incrementally with
> one additional commit since the last revision:
>
> Included suggestions
test/jdk/javax/swing/RepaintManager/RemoveInvalidComponentTest.java line 71:
> 69: JLabel label2 = new EqualLabel("label");
> 70:
> 71: System.out.println(label1.equals(label2));
I wonder whether it's better to enforce `label1.equals(label2)` returns `true`
and fail the test otherwise:
Suggestion:
if (!label1.equals(label2)) {
throw new RuntimeException("label1.equals(label2) returned false");
}
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30184#discussion_r2974992919
