On Fri, 20 Mar 2026 03:25:26 GMT, Prasanta Sadhukhan <[email protected]> wrote:
>> Few formatting issues were missed in >> [JDK-8380125](https://bugs.openjdk.org/browse/JDK-8380125) which needs to be >> fixed > > Prasanta Sadhukhan has updated the pull request incrementally with two > additional commits since the last revision: > > - Some more formatting fix > - Some more formatting fix Changes requested by dnguyen (Reviewer). src/java.desktop/share/classes/javax/swing/plaf/basic/BasicComboPopup.java line 1073: > 1071: > 1072: JList<?> list = getList(); > 1073: if (list != null && list.getComponentOrientation() != > o) { In this same file, there are instances of `for ( ` and `if ( ` where there are spaces after the `(`. Maybe you can correct these too by removing that following space since we're fixing formatting? There's a good number of them though. src/java.desktop/share/classes/javax/swing/plaf/basic/BasicMenuBarUI.java line 241: > 239: public void stateChanged(ChangeEvent e) { > 240: int i,c; > 241: for(i = 0,c = menuBar.getMenuCount() ; i < c ; i++) { Suggestion: for (i = 0, c = menuBar.getMenuCount(); i < c; i++) { ------------- PR Review: https://git.openjdk.org/jdk/pull/30310#pullrequestreview-4001814892 PR Review Comment: https://git.openjdk.org/jdk/pull/30310#discussion_r2983863510 PR Review Comment: https://git.openjdk.org/jdk/pull/30310#discussion_r2983851695
