On Tue, 24 Mar 2026 19:29:44 GMT, Damon Nguyen <[email protected]> wrote:
> There are two instances within harfbuzz where the conditional checks seem > impossible or redundant. I have removed these redundant checks and tested the > changes. Everything still works as expected. > > The !last_range check is logically redundant because there is the other check > if (unlikely (last_range)) beforehand in the same segment. This is > effectively similar to a null check. > > The next check for peak != 0 is also redundant. This is because of if (peak > == 0 || coord == peak) earlier in the code that returns 1.f. So all following > instructions should logically be when peak is not 0. This is upstream code. If there's a problem in it, report it upstream. Do not fix it in our copy. ------------- PR Comment: https://git.openjdk.org/jdk/pull/30412#issuecomment-4122123468
