On Fri, 27 Mar 2026 03:14:18 GMT, Jeremy Wood <[email protected]> wrote:
>> With this PR: VoiceOver correctly identifies a JToggleButton as a "toggle >> button" (instead of a "checkbox") >> >> This adds the subrole of NSAccessibilityToggleSubrole (which Accessibility >> Inspector shows as the subrole "AXToggle"). >> >> >> In the screenshot the subrole appears as expected, and the "class" (in the >> "element") section is different from production: >> >> <img width="1920" height="1080" alt="toggled button fixed" >> src="https://github.com/user-attachments/assets/b449e273-c089-4930-a968-9ea8643f3ac0"; >> /> > > Jeremy Wood has updated the pull request incrementally with two additional > commits since the last revision: > > - 8379347: clarify expected behavior for testers > > This is in response to: > https://github.com/openjdk/jdk/pull/30096#pullrequestreview-4018238446 > - 8379347: use text block > > This is in response to: > https://github.com/openjdk/jdk/pull/30096/changes#r2998420677 Looks good. ------------- Marked as reviewed by kizune (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/30096#pullrequestreview-4018847829
