On Wed, 25 Mar 2026 22:12:40 GMT, Jeremy Wood <[email protected]> wrote:

>> This fixes a bug in CommonComponentAccessibility.m: we were passing an 
>> AccessibleContext, when we should have been passing in an AccessibleAction.
>> 
>> This happened to work for most standard JComponents because many 
>> AccessibleContexts also implement AccessibleAction, but if the 
>> AccessibleAction was a separate object then this triggered a 
>> IncompatibleClassChangeError
>
> Jeremy Wood has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Update 
> test/jdk/javax/accessibility/8380849/AccessibleActionAsSeparateClassTest.java
>   
>   Co-authored-by: Andrey Turbanov <[email protected]>

@azuev-java @prsadhuk please review

src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/CommonComponentAccessibility.m
 line 1195:

> 1193:                            
> "(Ljavax/accessibility/Accessible;Ljava/awt/Component;)Ljavax/accessibility/AccessibleAction;",
>  FALSE);
> 1194: 
> 1195:     jobject axAction = (*env)->CallStaticObjectMethod(env, 
> sjc_CAccessibility, jm_getAccessibleAction, fAccessible, fComponent);

This looks reasonable to me but I'm not sufficiently familiar with this area to 
say more than that.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/30418#issuecomment-4156854750
PR Review Comment: https://git.openjdk.org/jdk/pull/30418#discussion_r3011284009

Reply via email to