On Fri, 17 Apr 2026 03:31:40 GMT, Jeremy Wood <[email protected]> wrote:

> This adds a null check in case SwingUtilities.getWindowAncestor is null.
> 
> Although I developed a jtreg test in the original ticket write-up for 
> 8382396, I later realized I can just ask the preexisting test for JDK-8170794 
> to run with different VM options to help test this issue.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Looks good to me.

I'll run the tests.

test/jdk/javax/swing/JDesktopPane/TestDesktopManagerNPE.java line 2:

> 1: /*
> 2:  * Copyright (c) 2026, Oracle and/or its affiliates. All rights reserved.

Suggestion:

 * Copyright (c) 2022, 2026, Oracle and/or its affiliates. All rights reserved.

You should always preserve the original year and modify or add the second year.

-------------

PR Review: https://git.openjdk.org/jdk/pull/30783#pullrequestreview-4131183433
PR Review Comment: https://git.openjdk.org/jdk/pull/30783#discussion_r3102444078

Reply via email to