On Sun, 19 Apr 2026 21:22:55 GMT, Archie Cobbs <[email protected]> wrote:

>> This PR adds a new compiler warning for `@SuppressWarnings` annotations that 
>> don't actually suppress any warnings.
>> 
>> Summary of code changes:
>> 
>> * Add new warning and associated lint category `"suppression"`
>> * Update `LintMapper` to keep track of which `@SuppressWarnings` 
>> suppressions have been validated ¹
>> * Update `Log.warning()` so it validates any current suppression of the 
>> warning's lint category in effect.
>> * Add a new `validate` parameter to `Lint.isEnabled()` and 
>> `Lint.isSuppressed()` that specifies whether to also validate any current 
>> suppression.
>> * Add `Lint.isActive()` to check whether a category is enabled _or_ 
>> suppression of the category is being tracked - in other words, whether the 
>> warning calculation needs to be performed. Used for non-trivial warning 
>> calculations.
>> * Add `-Xlint:-suppression` flags to `*.gmk` build files so the build 
>> doesn't break
>> 
>> ¹ The suppression of a lint category is "validated" as soon as it suppresses 
>> some warning in that category
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Archie Cobbs has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Add test to verfiy compiler ignores unknown categories per review 
> suggestion.

Even If this had to be "off by default". It is very useful to be able to turn 
it on when you want to check.

PS I think you were getting a hint to submit a CSR soon ...

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25167#issuecomment-4290728052
PR Comment: https://git.openjdk.org/jdk/pull/25167#issuecomment-4290734411

Reply via email to