Re: RFR: 8381007: MultiPixelPackedSampleModel can throw ArithmeticException [v3]

[Phil Race]

On Tue, 21 Apr 2026 08:03:28 GMT, Alexander Zvegintsev <azveg...@openjdk.org> 
wrote:

>> Phil Race has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   8381007
>
> src/java.desktop/share/classes/java/awt/image/MultiPixelPackedSampleModel.java
>  line 171:
> 
>> 169:             throw new IllegalArgumentException("scanlineStride must be 
>> > 0");
>> 170:         }
>> 171:         if (((numberOfBits * w) / DataBuffer.getDataTypeSize(dataType)) 
>> > scanlineStride) {
> 
> It looks like there might be an integer overflow here:
> 
> e.g. `new java.awt.image.MultiPixelPackedSampleModel(3, 77777777, 2, 32, 1, 
> 0)` is constructed successfully while it should not.

thanks, I remember  that crossing my mind but then forgot about it.
Fixed now, I think.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30826#discussion_r3119580042