On Tue, 21 Apr 2026 21:16:54 GMT, Alexander Zuev <[email protected]> wrote:
>>> If the caret is white and the bg is say rgb(2, 2,2) then you'll pass 256 >> >> No, i will not. The white is rgb(255, 255, 255) and bg is rgb(2, 2, 2) then >> i will pass rgb ((2 + 255) / 2, (2 + 255) / 2, (2 + 255) /2) which is >> rgb(128, 128, 128) which is gray - perfectly fits the purpose of the fix. > >> Would it be enough to change the alpha component of the caret only? > > Not sure it will work good on all color combinations so i did both added > alpha value of 50% and brought color half way to the background. > > If the caret is white and the bg is say rgb(2, 2,2) then you'll pass 256 > > No, i will not. The white is rgb(255, 255, 255) and bg is rgb(2, 2, 2) then i > will pass rgb ((2 + 255) / 2, (2 + 255) / 2, (2 + 255) /2) which is rgb(128, > 128, 128) which is gray - perfectly fits the purpose of the fix. You're right. I mis-read the parens. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30758#discussion_r3120463172
