On Wed, 22 Apr 2026 19:42:52 GMT, Alexey Ivanov <[email protected]> wrote:

>> Phil Race has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   8377568
>
> test/jdk/java/awt/image/DataBuffer/DataBufferGetSetElemTest.java line 134:
> 
>> 132:         try {
>> 133:             db.getElemFloat(index);
>> 134:         } catch (ArrayIndexOutOfBoundsException e) {
> 
> Suggestion:
> 
>         try {
>             db.getElemFloat(index);
>             failed = true;
>         } catch (ArrayIndexOutOfBoundsException e) {
> 
> Missed setting `failed` to `true`?
> 
> Or does this block repeat lines 127–131?

Yes, it is (or was, I've just deleted it) a harmless but pointless repeat

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29766#discussion_r3126539966

Reply via email to