On Wed, 22 Apr 2026 20:32:32 GMT, Phil Race <[email protected]> wrote:
>> Jeremy Wood has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8382201: reinstating correct properties
>>
>> I must have gotten my tickets mixed up when I removed these properties. We
>> DO want to toggle opengl (so we test both MTL and CGL), and we want volatile
>> images permanently off for this test.
>
> test/jdk/java/awt/GraphicsConfiguration/TranslucentDialogTest.java line 27:
>
>> 25: * @test
>> 26: * @bug 8382201
>> 27: * @summary This tests window translucency when
>
> The test needs
> @key headful
OK, this is updated
> test/jdk/java/awt/GraphicsConfiguration/TranslucentDialogTest.java line 30:
>
>> 28: * `swing.volatileImageBufferEnabled=false`
>> 29: * @requires os.family == "mac"
>> 30: * @library /java/awt/regtesthelpers
>
> I don't see any use of regtesthelpers here
OK, this is updated
> test/jdk/java/awt/GraphicsConfiguration/TranslucentDialogTest.java line 95:
>
>> 93: try {
>> 94: SwingUtilities.invokeAndWait(() -> {
>> 95: JDialog translucentDialog = createDialog();
>
> This dialog is never disposed, so you are relying on jtreg shutting the test
> down to cause the test to terminate.
OK, this is updated
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30737#discussion_r3126890972
PR Review Comment: https://git.openjdk.org/jdk/pull/30737#discussion_r3126891943
PR Review Comment: https://git.openjdk.org/jdk/pull/30737#discussion_r3126891545
