On Wed, 22 Apr 2026 23:38:58 GMT, lawrence.andrews <[email protected]> wrote:
>> Fixed the test instructions. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > lawrence.andrews has updated the pull request incrementally with one > additional commit since the last revision: > > Fixed the year Overall, the changes look good to me. However, I feel the test can be automated by using `Robot` to 1. click the drop-down button of the `JComboBox` (you can get the exact location of that button or use a small offset from the width); 2. type some text; 3. press `Enter`. Throw an exception to fail the test if `ActionEvent` isn't sent. test/jdk/javax/swing/JComboBox/JComboBoxActionEvent.java line 2: > 1: /* > 2: * Copyright (c) 2026, Oracle and/or its affiliates. All rights reserved. Suggestion: * Copyright (c) 2022, 2026, Oracle and/or its affiliates. All rights reserved. You shouldn't remove the original year, but add the current one. test/jdk/javax/swing/JComboBox/JComboBoxActionEvent.java line 53: > 51: Pass condition: a JOptionPane appears containing the > message ActionCommand received. > 52: Fail condition: the JOptionPane does not appear, or it > does not contain the expected message. > 53: """; Any reason to include `" "` (four spaces) indentation for each line of the instructions? ------------- Changes requested by aivanov (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/30887#pullrequestreview-4163656699 PR Review Comment: https://git.openjdk.org/jdk/pull/30887#discussion_r3131830703 PR Review Comment: https://git.openjdk.org/jdk/pull/30887#discussion_r3131866261
