On Sat, 14 Mar 2026 21:00:53 GMT, Jeremy Wood <[email protected]> wrote:

> On Mac OS: a "heading" has a special semantic meaning for assistive 
> technologies. It is a more accurate/useful role than "header" (which is a 
> Java construct and doesn't directly map to a Mac OS feature)
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Marked as reviewed by prr (Reviewer).

> In hindsight I wish I'd written the hyperlink PR ( #29686 ) to resemble this 
> PR:
> 
> ```
> - (NSAccessibilityRole)accessibilityRole
> {
>     if (fNSRole == nil) {
>         ...
>         if ( ... ) {
>             ...
>         } else if ( [javaRole isEqualToString:@"hyperlink"]) {
>             fNSRole = NSAccessibilityLinkRole;
>         }
> ```
> 
> I confirmed the hyperlink test still passes with this simpler implementation. 
> I assume reviewers here want me to not revise an already-closed ticket, 
> though.

If you want to revise that with a "better" fix. then. that's fine.

-------------

PR Review: https://git.openjdk.org/jdk/pull/30251#pullrequestreview-4165872645
PR Comment: https://git.openjdk.org/jdk/pull/30251#issuecomment-4307964833

Reply via email to