On Fri, 24 Apr 2026 18:05:30 GMT, Phil Race <[email protected]> wrote:

>> src/java.desktop/macosx/classes/sun/lwawt/macosx/CFileDialog.java line 149:
>> 
>>> 147:             if ((nativeCFileDialogPtr != 0L) && (nativeWindowID != 
>>> 0L)) {
>>> 148:                 nativeDispose();
>>> 149:             }
>> 
>> Why do we need the `nativeCFileDialogPtr` and the `nativeWindowID` at the 
>> java level?
>> It seems that they can be stored and checked in native within the 
>> `nativeDispose()` call.
>
> In order to be sure that these are the native pointers that are associated 
> with this Java Dialog Peer instance.

Ok, I guess it still can be done on native side, but it'll require more work.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30715#discussion_r3150167939

Reply via email to