On Wed, 22 Apr 2026 21:52:52 GMT, Phil Race <[email protected]> wrote:
>> This fix updates DataBuffer subclasses to actually adhere to their stated >> specifications by rejecting certain invalid parameters for constructors and >> getters and setters. >> A new egression test for each of the constructor and getter/setter cases is >> supplied. >> >> No existing regression tests fail with this change, and standard demos work. >> >> Problems caused by these changes are most likely to occur if the client has >> a bug such that >> - a client uses the constructors that accept an array and then supplies a >> "size" that is greater than the array. >> - a client uses the constructors that accept an array and then supplies a >> "size" that is less than the array and then uses getter/setters that are >> within the array but outside the range specified by size. >> >> Since very few clients (and just one case in the JDK that I found) even use >> these array constructors the changes are unlikely to make a difference to >> clients. >> >> The CSR is ready for review https://bugs.openjdk.org/browse/JDK-8378116 >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Phil Race has updated the pull request incrementally with one additional > commit since the last revision: > > 8377568 src/java.desktop/share/classes/java/awt/image/DataBuffer.java line 632: > 630: throw new ArrayIndexOutOfBoundsException("Invalid index > (offsets[" + bank + "]+i) is " + > 631: "(" + offsets[bank] + " + " + i + ") which is too large > for size : " + size); > 632: } The condition here should be `(i + offsets[bank] >= size)`. src/java.desktop/share/classes/java/awt/image/DataBuffer.java line 632: > 630: throw new ArrayIndexOutOfBoundsException("Invalid index > (offsets[" + bank + "]+i) is " + > 631: "(" + offsets[bank] + " + " + i + ") which is too large > for size : " + size); > 632: } I wonder whether the messages in the exceptions should use `getOffset()` or `getOffsets()` instead of member variables `offset` and `offsets`. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29766#discussion_r3155534546 PR Review Comment: https://git.openjdk.org/jdk/pull/29766#discussion_r3155542213
