On Wed, 29 Apr 2026 07:44:33 GMT, Jeremy Wood <[email protected]> wrote:

>> If `swing.volatileImageBufferEnabled` is turned off: MTLGraphicsConfig and 
>> CGLGraphicsConfig should use a translucent image for double buffering.
>> 
>> This test is marked as mac-only, but it should be harmless to turn that flag 
>> off if anyone wants to test other platforms. In previous threads we 
>> established that this is a Mac-only issue: 
>> https://github.com/openjdk/jdk/pull/23430#discussion_r1940881969
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Jeremy Wood has updated the pull request with a new target base due to a 
> merge or a rebase. The incremental webrev excludes the unrelated changes 
> brought in by the merge/rebase. The pull request contains 12 additional 
> commits since the last revision:
> 
>  - Merge remote-tracking branch 'origin/master' into 8382201
>  - 8382201: updating copyright year
>    
>    This is in response to:
>    https://github.com/openjdk/jdk/pull/30737#pullrequestreview-4179968243
>  - 8382201: fixing `@key headful`
>    
>    This is in response to:
>    https://github.com/openjdk/jdk/pull/30737/changes#r3127004349
>  - 8382201: removing regtesthelpers
>    
>    This is in response to:
>    https://github.com/openjdk/jdk/pull/30737#discussion_r3126755493
>  - 8382201: disposing dialog
>    
>    This is in response to:
>    https://github.com/openjdk/jdk/pull/30737#discussion_r3126753657
>  - 8382201: adding `@key headful`
>    
>    This is in response to:
>    https://github.com/openjdk/jdk/pull/30737#discussion_r3126749810
>  - 8382201: reinstating correct properties
>    
>    I must have gotten my tickets mixed up when I removed these properties. We 
> DO want to toggle opengl (so we test both MTL and CGL), and we want volatile 
> images permanently off for this test.
>  - 8382201: adding extra {}'s for code review
>  - 8382201: resetting RepaintManager so diff is clean
>  - 8382201: removing isWrongOpacity
>    
>    Also simplifying unit test so it doesn't require a white background Frame.
>    
>    The opacity issue is important, but it can be represented as a separate 
> ticket. (I'm trying to keep PRs as simple as possible to speed up/simplify 
> code review.)
>  - ... and 2 more: https://git.openjdk.org/jdk/compare/1515b21a...854c9146

@mickleness 
Your change (at version 854c9146f6ca766031b954bd3721392b830d200e) is now ready 
to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/30737#issuecomment-4361277382

Reply via email to