On Tue, 5 May 2026 14:10:53 GMT, Alan Bateman <[email protected]> wrote:
>> src/java.base/share/classes/sun/launcher/LauncherHelper.java line 1131: >> >>> 1129: // this method is only called if we can find the module >>> 1130: // in the first place, so it will always be present >>> 1131: Module om = >>> ModuleLayer.boot().findModule(JAVAFX_GRAPHICS_MODULE_NAME).orElseThrow(); >> >> Even though this will now never be called unless >> `findModule(JAVAFX_GRAPHICS_MODULE_NAME)` is present, it seems cleaner and >> less intrusive to revert the changes in this method. > > orElseThrow(InternalError::new) would be okay too. I reverted the changes to the old version and kept the comment for clarity ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31016#discussion_r3189290792
