On Tue, 5 May 2026 15:42:18 GMT, Alan Bateman <[email protected]> wrote:
>> Christopher Schnick has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Revert optional check and move constant to proper scope > > src/java.base/share/classes/sun/launcher/LauncherHelper.java line 1129: > >> 1127: // find the module with the FX launcher >> 1128: // this method is only called if we can find the module >> 1129: // in the first place, so it will always be present > > I would prefer if the comment were reverted as the update/wording is very > confusing. Alright, I can do that as well ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31016#discussion_r3190157591
