On Wed, 6 May 2026 04:24:31 GMT, Prasanta Sadhukhan <[email protected]> wrote:
>> yes 'of' is missing (typo) >> But we aren't going to use the word "edit" since what the app is going to do >> with the file is up to the app. > > But "edit" is already being used in the current phrase > >> or to edit in the name some other file to load/open > > so I used that but in a simpler manner atleast to me..But if it is considered > ok, then I am good.. GitHub is being very annoying since I can't locate the original comment to reply to. "Edit" in the javadoc in the PR is about the user "editing" the contents of the textfield right in front of them. ie editing the name of the file. You used "edit" in the sense of what the app does with the file represented by what getFile() returns - specifically you implied an editor would be opened on the file. Completely different. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30777#discussion_r3198932288
