On Thu, 14 May 2026 21:58:25 GMT, Sergey Bylokhov <[email protected]> wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8381007
>
> src/java.desktop/share/classes/java/awt/image/MultiPixelPackedSampleModel.java
> line 169:
>
>> 167: }
>> 168: if (scanlineStride <= 0) {
>> 169: throw new IllegalArgumentException("scanlineStride must be
>> > 0");
>
> This `scanlineStride <= 0` check is not documented in the spec. And it seems
> is not triggered by the test.
It looks like an oversight. I will add it.
> test/jdk/java/awt/image/MultiPixelPackedSampleModelConstructor.java line 24:
>
>> 22: */
>> 23:
>> 24: import static java.awt.image.DataBuffer.*;
>
> Usually static imports are placed last with one empty line between non-static
> and static imports. "*" can be replaced with the specific classes.
I expanded it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30826#discussion_r3251071155
PR Review Comment: https://git.openjdk.org/jdk/pull/30826#discussion_r3251122666
