On Tue, 2 Jun 2026 09:04:17 GMT, Arno Zeller <[email protected]> wrote:

> The doInBackground working loop is left because of the loop condition 
> (!Thread.currentThread().isInterrupted()) - this will not clear the 
> interrupted status of the thread and the Thread.sleep at line 63 will throw 
> an InterruptedException directly.
> I suggest to change two things:
> No longer check the !Thread.currentThread().isInterrupted() but rely only on 
> the Thread.sleep to throw an InterrutedException.
> And using a countdown latch instead of a sleep to ensure that we really 
> entered the loop before we do cancel the worker.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

test/jdk/javax/swing/SwingWorker/TestDoneBeforeDoInBackground.java line 46:

> 44:     private static final AtomicBoolean doneFinished = new 
> AtomicBoolean(false);
> 45:     private static final CountDownLatch doneLatch = new CountDownLatch(1);
> 46:     private static final CountDownLatch workerStarted = new 
> CountDownLatch(1);

Should we update the copyright year.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31348#discussion_r3346417778

Reply via email to