On Thu, 11 Jun 2026 08:58:32 GMT, Jayathirth D V <[email protected]> wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8041911
>
> src/java.desktop/share/classes/javax/print/attribute/standard/MediaSize.java
> line 39:
>
>> 37: * class that indicates the dimensions of the medium in a portrait
>> orientation,
>> 38: * with the {@code X} dimension running along the bottom edge and the
>> {@code Y}
>> 39: * dimension running along the left edge. Thus, the {@code Y} dimension
>> must be
>
> The class level documentation also should be updated. Since we allow Y < X
> now.
I have updated the class doc wording.
> src/java.desktop/share/classes/sun/print/CustomMediaSizeName.java line 212:
>
>> 210: new MediaSize(width, length, Size2DSyntax.INCH,
>> value);
>> 211: } catch (IllegalArgumentException e) {
>> 212: // Should not happen, keep for safety
>
> Can we just remove this try/catch block?
> Why should we consume IAE? Is there some compatibility issue?
Just the reason in the updated comment - for safety. I can remove it, I just
had thought it prudent to keep it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31226#discussion_r3439015310
PR Review Comment: https://git.openjdk.org/jdk/pull/31226#discussion_r3439019139
