On Tue, 30 Jun 2026 17:20:59 GMT, Daniel Gredler <[email protected]> wrote:
>> Yes, I think they're safe to delete now: both the comment and the `ifndef`.
>>
>> Windows XP introduced visual styles, and the menu bar and pop-up menus have
>> different background colors.
>
>> [URL] says about COLOR_MENUBAR: Windows 2000, Windows 10 or greater: This
>> value is not supported
>
> I think that means it's still defined as a constant (so no need for the
> `ifndef`), just not fully usable as a parameter in some places. Checked
> locally on Windows 11 25H2 (build 26200.8655):
>
>
> #include <windows.h>
> #include <stdio.h>
>
> int main(void) {
> printf("COLOR_MENUBAR = %d\n", COLOR_MENUBAR);
> printf("GetSysColor(COLOR_MENUBAR) = 0x%08lX\n",
> GetSysColor(COLOR_MENUBAR));
> return 0;
> }
>
>
> Output:
>
>
> COLOR_MENUBAR = 30
> GetSysColor(COLOR_MENUBAR) = 0x00F0F0F0
Okay, thanks for looking into this! So probably we can remove the additional
defines of COLOR_MENUBAR.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31676#discussion_r3504140406
