On Fri, 3 Jul 2026 09:10:29 GMT, Matthias Baesken <[email protected]> wrote:
>> src/java.desktop/windows/native/libawt/windows/awt.h line 158: >> >>> 156: >>> 157: #define IS_WIN8 ( >>> \ >>> 158: (LOBYTE(LOWORD(::GetVersion())) == 6 && >>> (HIBYTE(LOWORD(::GetVersion())) >= 2)) || \ >> >> I'd be surprised if anyone runs the JVM on OSes pre-Windows-8, so that one >> can probably vanish, too. Windows 7 went EOL in 2020. > > We set flags in the autoconf files to 'compile as if my application requires > at least Windows 8' . > See > > flags-cflags.m4-524- elif test "x$TOOLCHAIN_TYPE" = xmicrosoft; then > flags-cflags.m4:525: # _WIN32_WINNT=0x0602 means access APIs for Windows 8 > and above. See > flags-cflags.m4-526- # > https://docs.microsoft.com/en-us/cpp/porting/modifying-winver-and-win32-winnt?view=msvc-170 > flags-cflags.m4:527: ALWAYS_DEFINES="-DWIN32_LEAN_AND_MEAN > -D_WIN32_WINNT=0x0602 \ > flags-cflags.m4-528- -D_CRT_DECLARE_NONSTDC_NAMES > -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_WARNINGS" > flags-cflags.m4-529- ALWAYS_DEFINES_JDK="$ALWAYS_DEFINES -DWIN32 -DIAL" > flags-cflags.m4-530- ALWAYS_DEFINES_JVM="$ALWAYS_DEFINES -DNOMINMAX" Cool, then you could also remove IS_WIN8 since its always true ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31762#discussion_r3519752926
