On Fri, 10 Jul 2026 11:06:21 GMT, Alexey Ivanov <[email protected]> wrote:
>> src/java.desktop/windows/native/libawt/windows/awt_FileDialog.cpp line 115: >> >>> 113: } >>> 114: >>> 115: WNDPROC lpfnWndProc = (WNDPROC)(::GetProp(hWnd, >>> NativeDialogWndProcProp)); >> >> The corresponding `::SetProp` at line 157 should also be removed. >> >> https://github.com/openjdk/jdk/blob/978dfecb6545166aee93a8e68c9c82535b0cb3e2/src/java.desktop/windows/native/libawt/windows/awt_FileDialog.cpp#L155-L157 >> >> Also, `::RemoveProp` for `NativeDialogWndProcProp` is to be removed: >> >> https://github.com/openjdk/jdk/blob/978dfecb6545166aee93a8e68c9c82535b0cb3e2/src/java.desktop/windows/native/libawt/windows/awt_FileDialog.cpp#L175 >> >> --- >> >> `SubclassHWND` always returns `NULL`. >> >> https://github.com/openjdk/jdk/blob/978dfecb6545166aee93a8e68c9c82535b0cb3e2/src/java.desktop/windows/native/libawt/windows/ComCtl32Util.cpp#L44-L47 >> >> Removing the return value from `SubclassHWND` is a candidate for another >> cleanup? Or it could be included in this PR. > > The property name itself, `NativeDialogWndProcProp`, could be removed if it's > not used after this PR, which should be the case. We still use it below at line 202 ` LPOPENFILENAME lpofn = (LPOPENFILENAME)GetProp(parent, OpenFileNameProp);` so I am not sure about this whole OpenFileNameProp removal ? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31814#discussion_r3559404024
