On Thu, 16 Jul 2026 03:09:21 GMT, Prasanta Sadhukhan <[email protected]>
wrote:
>> src/java.desktop/windows/classes/sun/java2d/windows/WindowsFlags.java line
>> 172:
>>
>>> 170: "javax.accessibility.screen_magnifier_present", false);
>>> 171: boolean ddEnabled =
>>> 172: getBooleanProp("sun.java2d.d3d", magPresent);
>>
>> It is one thing to update the tests to use the d3d property, but another
>> thing to remove the recognition of noddraw. This would be a compatibility
>> issue for apps that set it.
>> This would need a CSR too. Also ddEnabled becomes obsolete.
>>
>> You should consider backing off from making these source changes and just
>> update the tests.
>
> @prrace Any comment on this
> https://github.com/openjdk/jdk/pull/31750#discussion_r3565859430 which will
> not remove the property technically but will render it no-op from internal
> jdk ?
I would not recommend setting a property which is expected to be set only by
apps, based on some other property.
And looking at the code where d3d being explicitly set to true over-rides draw
being explicitly set to false, I don't see a possible simplification of the
code that preserves the behaviour, and I expect that would also complicate or
rule out the property setting option.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31750#discussion_r3605189007
