On Wed, 22 Jul 2026 07:52:23 GMT, Matthias Baesken <[email protected]> wrote:
>> [JDK-8387298](https://bugs.openjdk.org/browse/JDK-8387298) removed the >> IS_WINXP macro, and the updated code in ComCtl32Util::UnsubclassHWND and >> ComCtl32Util::DefWindowProc doesn't use the _DefWindowProc parameter any >> more. >> >> Thus, the _DefWindowProc parameter can be removed from these functions. >> >> Removing these parameters requires updating all the usages of the functions, >> for example, in awt_Component.cpp, awt_Choice.cpp... >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Matthias Baesken has updated the pull request incrementally with one > additional commit since the last revision: > > Remove more unneeded lpfnWndProc local vars Btw. `m_DefWindowProc` seems to be obsolete now too. We declare it, set it now at 2 places to NULL and otherwise do nothing with it. grep -nH -r m_DefWindowProc * windows/native/libawt/windows/awt_Component.cpp:232: m_DefWindowProc = NULL; windows/native/libawt/windows/awt_Component.cpp:686: m_DefWindowProc = NULL; windows/native/libawt/windows/awt_Component.h:783: WNDPROC m_DefWindowProc; (but not sure if we want to remove it in this pr) ------------- PR Comment: https://git.openjdk.org/jdk/pull/31814#issuecomment-5043371037
