On Tue, 28 Jul 2026 13:23:54 GMT, Christoph Langer <[email protected]> wrote:

>> Currently we have no configure option to disable the build of libjsound, so 
>> we always try to build it and need the related dependencies.
>> an exception is AIX where we have the build disabled; it might make sense to 
>> offer a configure option to disable the jsound build e.g. to build a 
>> headless jdk for container envs where we do not have sound (the JCK offers 
>> options to have a JDK without sound).
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> make/modules/java.desktop/Lib.gmk line 41:
> 
>> 39: 
>> 40: ifeq ($(ENABLE_JSOUND), true)
>> 41: ifeq ($(call isTargetOs, aix), false)
> 
> I think these two ifeqs (!aix and enable_jsound) can be folded into one.

I think it is better readable the way it is. This 'true+false' looks not so 
convincing to me here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31951#discussion_r3672337203

Reply via email to