On Thu, 30 Jul 2026 11:09:00 GMT, Prasanta Sadhukhan <[email protected]> 
wrote:

> Aqua classes for text components enables dragEnabled by default although 
> setDragEnabled spec cites `"The default value of the dragEnabled property is 
> false. "` and there is nothing in Aqua L&F that mentions otherwise as to why 
> the default is overridden.
> Other L&F dont override the mode and the code is there from macosx port days 
> so it seems to be an oversight.
> 
> The code is deleted.
> Test is added to check 
>  - default value is honoured in all installed L&Fs
>  - explicit application setting of drag mode is preserved on L&F change
> 
>  CI testing is ok.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Marked as reviewed by azvegint (Reviewer).

test/jdk/javax/swing/text/JTextComponent/TextComponentDragEnabledTest.java line 
36:

> 34: 
> 35: import javax.swing.JEditorPane;
> 36: import javax.swing.JPasswordField;

`JPasswordField` is not currently used, but it could be added to the test, 
along with `JFormattedTextField`.

-------------

PR Review: https://git.openjdk.org/jdk/pull/32101#pullrequestreview-4821272594
PR Review Comment: https://git.openjdk.org/jdk/pull/32101#discussion_r3684661698

Reply via email to