On Mon, 3 Aug 2026 10:59:53 GMT, Matthias Baesken <[email protected]> wrote:
> I think there is no need for the unused `bool freeData = false;` because we > simply should always dynamically allocate the buffers in question (and of > course always free them after usage). Btw. seems `printVersion()` leaks > memory too > https://github.com/openjdk/jdk/blob/4a9fba615da0dfa6646ecb9fd9d929f74fe6875e/src/jdk.accessibility/windows/native/jabswitch/jabswitch.cpp#L299C11-L299C23 > So all the usages of new in this file need updating. > > So I would say just integrate this PR, but right afterwards fix the > new/delete issues in jabswitch.cpp (I would be okay to prepare a follow up PR > for this, because no one seems to work atm. on the existing issue > [JDK-8348872](https://bugs.openjdk.org/browse/JDK-8348872) ). Comments ? Would be great to get the number of reviewers lowered to 2 again. I plan to continue with the leaks afterwards in another PR this week. ------------- PR Comment: https://git.openjdk.org/jdk/pull/32088#issuecomment-5189237986
