On Wed, 5 Aug 2026 18:28:49 GMT, Phil Race <[email protected]> wrote:

> >   
> > Shouldn't GlobalUnlock be called on the handle (glob) and NOT on the 
> > pointer (`pFileListWithDoubleZeroTerminator` ) ?
> 
> Yes, the current code looks wrong. It probably isn't going to cause any 
> functional issues, but it likely prevents the memory from ever being freed, 
> because it is used in CreateStreamOnHGlobal() which requires a movable 
> handle, so the value is not going to be recognized by GlobalUnlock

I adjusted the GlobalUnlock call.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/32206#issuecomment-5202198551

Reply via email to