On Thu, 6 Aug 2026 15:02:54 GMT, Matthias Baesken <[email protected]> wrote:
> --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). This looks OK to me but I want @azuev-java to review (and test) it. src/jdk.accessibility/windows/native/jabswitch/jabswitch.cpp line 344: > 342: wsprintf(newStr, L"%s,%s", dataBuffer, > STR_ACCESSBRIDGE); > 343: RegSetValueEx(hKey, ACCESSIBILITY_CONFIG, 0, REG_SZ, > (BYTE *)newStr, dataLength); > 344: delete[] newStr; It seems unlikely that windows takes ownership of this memory, so we should free it. However given that jabswitch is very emphemeral as an app, leaks are not a big deal. ------------- Marked as reviewed by prr (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/32236#pullrequestreview-4878602937 PR Review Comment: https://git.openjdk.org/jdk/pull/32236#discussion_r3732285123
