On Wed, 12 Aug 2026 06:25:38 GMT, Prasanta Sadhukhan <[email protected]> wrote:
>> Aqua classes for text components enables dragEnabled by default although >> setDragEnabled spec cites `"The default value of the dragEnabled property is >> false. "` and there is nothing in Aqua L&F that mentions otherwise as to why >> the default is overridden. >> Other L&F dont override the mode and the code is there from macosx port days >> so it seems to be an oversight. >> >> The code is deleted. >> Test is added to check >> - default value is honoured in all installed L&Fs >> - explicit application setting of drag mode is preserved on L&F change >> >> CI testing is ok. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional commit since the last revision: > > Check for headless src/java.desktop/share/classes/javax/swing/JComponent.java line 4199: > 4197: } else if ("dragEnabled".equals(propertyName) > 4198: && this instanceof JTextComponent textComponent) { > 4199: if (!GraphicsEnvironment.isHeadless()) { You have dropped the "GraphicsEnvironment.isHeadless" check in uninstallDefaults but left it in installDefaults, I assume that after this change the check in Aqua is not needed in both? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32101#discussion_r3772688333
