On Thu, 27 Aug 2026 09:06:04 GMT, Matthias Baesken <[email protected]> wrote:
>> There is a RegOpenKeyExA call present, but we do not close the handle. This >> should be changed. >> The MS docu says >> https://learn.microsoft.com/en-us/windows/win32/api/winreg/nf-winreg-regopenkeyexa >> 'A pointer to a variable that receives a handle to the opened key. If the >> key is not one of the predefined registry keys, call the >> [RegCloseKey](https://learn.microsoft.com/en-us/windows/desktop/api/winreg/nf-winreg-regclosekey) >> function after you have finished using the handle.' >> And in this coding we call >> `LONG lRet = ::RegOpenKeyExA(hRootKey, lpszSubKey, 0, KEY_ALL_ACCESS, &hKey); >> ` >> with a non_NULL `lpszSubKey `so the RegCloseKey has to be done. >> >> Also fixed a typo while at it. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Matthias Baesken has updated the pull request incrementally with one > additional commit since the last revision: > > Add assert on lpszSubKey length Thanks for the reviews ! ------------- PR Comment: https://git.openjdk.org/jdk/pull/32249#issuecomment-5474857202
