On Wed, 9 Sep 2026 07:37:35 GMT, Jayathirth D V <[email protected]> wrote:

> Locally i see that this test fails intermittently because of timing issues.
> Made test more robust and test now passes on all platforms.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

test/jdk/sun/java2d/DirectX/OverriddenInsetsTest/OverriddenInsetsTest.java line 
60:

> 58:             getColorModel().getPixelSize() < 16)
> 59:         {
> 60:             System.out.println("<16 bit mode detected, test passed");

It looks like the return statement is missing.

test/jdk/sun/java2d/DirectX/OverriddenInsetsTest/OverriddenInsetsTest.java line 
133:

> 131:             g.drawRect(0,0,getWidth() - 1,getHeight() - 1);
> 132:             g.setColor(Color.blue);
> 133:             g.fillRect(0,0,getWidth() / 2,getHeight() / 2);

Suggestion:

            g.drawRect(0, 0, getWidth() - 1, getHeight() - 1);
            g.setColor(Color.blue);
            g.fillRect(0, 0, getWidth() / 2, getHeight() / 2);

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/32779#discussion_r3969619328
PR Review Comment: https://git.openjdk.org/jdk/pull/32779#discussion_r3969615139

Reply via email to