On Sun, 27 Sep 2026 02:12:07 GMT, Sergey Bylokhov <[email protected]> wrote:
>> Alexander Zvegintsev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review comments
>
> src/java.desktop/unix/native/libawt_xawt/awt/screencast_pipewire.c line 319:
>
>> 317: if (!spaBuffer
>> 318: || spaBuffer->n_datas < 1
>> 319: || spaBuffer->datas[0].data == NULL) {
>
> Should this code check the "chunk" for NULL as well?
Check added.
> src/java.desktop/unix/native/libawt_xawt/awt/screencast_pipewire.c line 321:
>
>> 319: || spaBuffer->datas[0].data == NULL) {
>> 320: DEBUG_SCREEN_PREFIX(screen, "!!! no data, n_datas %d\n",
>> 321: spaBuffer ? (int) spaBuffer->n_datas : -1);
>
> seems fp_pw_stream_queue_buffer(data->stream, pwBuffer); is missing on this
> return?
Yes, updated.
> src/java.desktop/unix/native/libawt_xawt/awt/screencast_portal.c line 121:
>
>> 119: struct ScreenProps *newScreens = realloc(
>> 120: screenSpace.screens,
>> 121: ++screenSpace.allocated * sizeof(struct ScreenProps)
>
> ++screenSpace.allocated should be bumped on success only?
updated.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/33059#discussion_r4119866937
PR Review Comment: https://git.openjdk.org/jdk/pull/33059#discussion_r4119869727
PR Review Comment: https://git.openjdk.org/jdk/pull/33059#discussion_r4119870693
