On Fri, 25 Sep 2026 17:56:02 GMT, Phil Race <[email protected]> wrote:
>> FWIW, Default font works now in all platforms in most recent versions of the >> OS in CI systems but since it has failed in the past, there's no surety that >> it will pass when the next OS versions with different system font come along. >> Also, I guess default font in macos uses same as Dialog and as pointed out, >> we were being lucky that it passes with that font, so we are trying to >> stabilize with a known font that will remain stable even if default system >> font changes. > > No, it should work with DIALOG on Windows & Linux. You can revert that change. > We aren't trying to stabilise with a known font. That idea has been debunked > as being the problem. > Ideally we should make this test try EVERY font on the system and it should > pass with all of them. But, with DIALOG font instead of MONOSPACED, everything else remaining same, it passes in Windows, Linux and even macos (already mentioned here https://github.com/openjdk/jdk/pull/32742#issuecomment-5633538857) so there will be no need of PL-ing the test then.. I tried testing by iterating with all available fonts but it fails in Windows Testing font=**Arial Black** aa=false, graphicsTransform=AffineTransform[[-0.707106781186548, -0.707106781186548, 0.0], [0.707106781186548, -0.707106781186548, 0.0]], fontTransform=AffineTransform[[1.0, -0.0, 0.0], [0.0, 1.0, 0.0]] Exception in thread "main" java.lang.RuntimeException: Failed: wrong colors at i=0 j= 221 rgb1 java.awt.Color[r=0,g=0,b=0] rgb2 java.awt.Color[r=0,g=0,b=0] at DrawRotatedStringUsingRotatedFont.checkColors(DrawRotatedStringUsingRotatedFont.java:135) and in Linux ubuntu 24.04 Testing font=**C059 Bold Italic** aa=false, graphicsTransform=AffineTransform[[-0.707106781186548, -0.707106781186548, 0.0], [0.707106781186548, -0.707106781186548, 0.0]], fontTransform=AffineTransform[[1.0, -0.0, 0.0], [0.0, 1.0, 0.0]] Exception in thread "main" java.lang.RuntimeException: Failed: wrong colors at i=0 j= 221 rgb1 java.awt.Color[r=0,g=0,b=0] rgb2 java.awt.Color[r=0,g=0,b=0] at DrawRotatedStringUsingRotatedFont.checkColors(DrawRotatedStringUsingRotatedFont.java:135) ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32742#discussion_r4119468444
