On Wed, 23 Sep 2026 17:56:32 GMT, Phil Race <[email protected]> wrote:
>> A fix for a theoretical NPE because a method might return null and it is >> used. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Phil Race has updated the pull request incrementally with one additional > commit since the last revision: > > 8385017 src/java.desktop/share/classes/com/sun/media/sound/SoftVoice.java line 624: > 622: osc_stream = resampler; > 623: } catch (IOException e) { > 624: osc_stream = null; Seem in this particular case the osc_stream should be checked for null and if not then "osc_stream.close()" should be called? IOException may occur in resampler.open() and we need to close the old one? Or possibly we should close the old one first then try to open the new one? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31299#discussion_r4124428948
